[Repo Assist] Design parity with TaskSeq, batch 2 (#277)#281
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
[Repo Assist] Design parity with TaskSeq, batch 2 (#277)#281github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Add 11 functions missing from AsyncSeq relative to FSharp.Control.TaskSeq: - tryTail, where/whereAsync, lengthBy/lengthByAsync, compareWith/compareWithAsync - takeWhileInclusiveAsync, skipWhileInclusive/skipWhileInclusiveAsync - appendSeq/prependSeq, delay, collectAsync, partition/partitionAsync Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Continues the design-parity work tracked in #277 by adding 11 more functions that are present in
FSharp.Control.TaskSeqbut were missing fromAsyncSeq.All functions follow existing
AsyncSeqnaming conventions (sync + async variants where applicable), include XML-doc, are covered by new tests, and compile with no new warnings.New functions
tryTailNoneif empty; otherwiseSome(tail)TaskSeq.tryTailwhere/whereAsyncfilter/filterAsyncTaskSeq.where/whereAsynclengthBy/lengthByAsyncTaskSeq.lengthBy/lengthByAsynccompareWith/compareWithAsyncTaskSeq.compareWith/compareWithAsynctakeWhileInclusiveAsynctakeWhileInclusiveTaskSeq.takeWhileInclusiveAsyncskipWhileInclusive/skipWhileInclusiveAsyncTaskSeq.skipWhileInclusive/skipWhileInclusiveAsyncappendSeqseq<'T>after an async sequenceTaskSeq.appendSeqprependSeqseq<'T>before an async sequenceTaskSeq.prependSeqdelayTaskSeq.delaycollectAsynccollectbut with an'T -> Async(AsyncSeq<'U)>mappingTaskSeq.collectAsyncpartition/partitionAsyncTaskSeq.partition/partitionAsyncRemaining gap (not in this PR)
These items from the original analysis in #277 remain for future work:
insertManyAt/removeManyAt— bulk index-based insert/removeexceptOfSeq—exceptthat takesseqrather thanAsyncSeqbox/unbox/cast— type helpers (lower priority)lengthOrMax— capped length (lower priority)Changes
src/FSharp.Control.AsyncSeq/AsyncSeq.fs— 11 new function implementationssrc/FSharp.Control.AsyncSeq/AsyncSeq.fsi— 18 new public signatures with XML-doctests/FSharp.Control.AsyncSeq.Tests/AsyncSeqTests.fs— 23 new testsRELEASE_NOTES.md— 4.11.0 entryversion.props— bumped to 4.11.0Test Status
✅ Build succeeded (0 errors, pre-existing warnings only — NU1605, FS9999 for
groupByAsync).✅ All 348 tests pass (
dotnet test tests/FSharp.Control.AsyncSeq.Tests/...) — 25 new, 323 pre-existing.Related to We want design parity with FSharp.Control.TaskSeq #277
Fixes We want design parity with FSharp.Control.TaskSeq #277